Add cp and cp_rm transfer implementations (rebased onto dev_5_0) #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by Niko on the forums, cp and cp_rm implementations make local transfer of files possible even across filesystem boundaries. The trade-off is of course that in the case of a failed transfer there will be increased space used which will need to be manually cleaned up. See: https://www.openmicroscopy.org/community/viewtopic.php?f=5&t=7699
All non-upload transfer mechanisms were leaving the file size in the database set to the size of the UUID file (36 bytes). By re-checking the file size, the new isModified method can prevent this.
joshmoore
force-pushed
the
rebased/dev_5_0/cp_rm
branch
from
0000000
to
e18bc9c
Compare
|
--rebased-from #3335 |
|
This all looks good to merge. |
|
Thanks, @ximenesuk. Responding on https://www.openmicroscopy.org/community/viewtopic.php?f=5&t=7699 as well. |
joshmoore
added a commit
that referenced
this pull request
Jan 26, 2015
Add cp and cp_rm transfer implementations (rebased onto dev_5_0)
This was referenced Jan 26, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as gh-3335 but rebased onto dev_5_0.
As suggested by Niko on the forums, cp and cp_rm
implementations make local transfer of files possible
even across filesystem boundaries. The trade-off is
of course that in the case of a failed transfer there
will be increased space used which will need to be
manually cleaned up.
See: https://www.openmicroscopy.org/community/viewtopic.php?f=5&t=7699
/cc @ximenesuk