New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cp/_rm section for 5.0.7 #1079
Conversation
This looks good but in looking at the built docs I noticed that the, not strictly in-place, transfer option "upload_rm" isn't yet documented so this might be a good PR for that to sit in. The comparison between the "cp" group and the "ln" group is fine but why "cp" over "upload"? That comparison should be stated somewhere hereabouts too. |
Happy to add in |
@ximenesuk : copied the minimal blurb from #975, but obviously you did much more there. Do we want to go further? /cc @hflynn |
Looks good to me. A sentence hinting at the benefits of |
I'm inclined to keep it a bit simple for 5.0.7. During the rebase, I'll see if it can be more tightly tied into your other fixes. @hflynn, this is all yours. |
Erm, sorry to come at this late but if this isn't actually in-place import stuff, would it not be better documented on https://www.openmicroscopy.org/site/support/omero5-staging/sysadmins/import-scenarios.html or at least signposting further up the page ? |
|
Ah ok, sorry, I obviously got the wrong end of the stick. |
Re-running the merge build now but this is looking fine to me in that case. I'm inclined to agree about leaving the extra stuff on 5.1.0 only since we already decided not to rebase #975 |
Yes, I think in-place may now be a misplaced term! All 5.x imports are effectively in-place, it's just what you do before and after the import that differs! |
We do like to pick our terminology! |
Looks fine on staging. merging. |
--rebased-to #1087 |
See: ome/openmicroscopy#3379