Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROI service #4261

Merged
merged 1 commit into from Oct 14, 2015
Merged

ROI service #4261

merged 1 commit into from Oct 14, 2015

Conversation

jburel
Copy link
Member

@jburel jburel commented Oct 13, 2015

Deprecate methods in ROIService
I had to mark each method as deprecated in the slice so it is reflected in Java
There is maybe a more suitable way
cc @joshmoore

@joshmoore
Copy link
Member

Makes sense. If we do decide to salvage anything from IRoi we can just put it under IRoi2 or whatever it will be called. This will give everyone maximal warning.

joshmoore added a commit that referenced this pull request Oct 14, 2015
@joshmoore
Merge pull request #4261 from jburel/deprecate-roi-service
0c7ae4a 
ROI service
@joshmoore joshmoore merged commit 0c7ae4a into ome:develop Oct 14, 2015
@sbesson sbesson added this to the 5.2.0 milestone Oct 28, 2015
@jburel jburel deleted the deprecate-roi-service branch January 19, 2016 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
develop
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jburel @joshmoore @sbesson