add Experimenter.config and lengthen Session.userIP #4762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes trac 13254
| @pytest.mark.parametrize("client_ip", [ | ||
| "127.0.0.1", | ||
| "2400:cb00:2048:1::6814:55", | ||
| "1234:5678:1234:5678:1234:5678:121.212.121.212"]) |
There was a problem hiding this comment.
for the curious reviewer, this imitates an IPv4-mapped IPv6 address from a dual-stack node
|
Changes all match my expectations. |
|
@jburel: Looks good to you? If so I'll remove from breaking. |
|
looks good @mtbc |
mtbc
added a commit
to mtbc/openmicroscopy
that referenced
this pull request
Feb 8, 2017
should probably have been in ome#4762 really
mtbc
added a commit
to mtbc/openmicroscopy
that referenced
this pull request
Mar 2, 2017
should probably have been in ome#4762 really
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a new map annotation property
Experimenter.configfor expanding permissions. LengthensSession.userIPso that it can accommodate IPv6 addresses.Testing this PR
Try using
Experimenter.config. For instance, as root,Check if one can log in to OMERO from an IPv6 host if convenient, but note new coverage by
testSessionWithIPat https://ci.openmicroscopy.org/job/OMERO-DEV-merge-integration-python/lastCompletedBuild/testReport/OmeroPy.test.integration.test_isession/TestISession/.Related reading
https://trello.com/c/t0nT7KYa/35-new-role and http://trac.openmicroscopy.org/ome/ticket/13254.