-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra licensing, minutes & support -> docs redirects #56
Conversation
I realize I could also redirect more of the minutes/meetings/ URLs now the older user meetings are live but I'll do that on a follow up PR along with the other items we've identified rather than add even more here. |
Deployed on ome-www-dev. The licensing and minutes redirect seems to work but not the support redirects. I will take a look at it tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having reviewed the different combinations, the matrix belows gives a summary of the redirects state for the site/support/bio-formats
URLs
I think the following redirect structure should address all cases
- match: " ~/site/support/bio-formats(?<link>/.*)?$"
dest: https://docs.openmicroscopy.org/latest/bio-formats$link
Sorry @sbesson I don't know why this is failing travis - the error message is about nginx and doesn't look related to my changes |
www/www-deploy.yml
Outdated
- match: "~/site/support/bio-formats/(?<link>.*[^/])/?$" | ||
dest: https://docs.openmicroscopy.org/latest/bio-formats/$link/ | ||
- match: "~/site/support/bio-formats(?<link>/.*)?$" | ||
dest: https://docs.openmicroscopy.org/latest/bio-formats$link; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry the trailing ;
(copied pasted from #56 (review)) needs to be removed as it prevents nginx
from starting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I thought they were a bit random, should have checked with you!
@sbesson passing travis now at least! |
Deployed live on www.openmicroscopy.org
|
Add extra licensing, minutes & support -> docs redirects
When testing the redirect for https://trello.com/c/riJnvMrD/147-downloads-page-cc-license-link I noticed the link behind the "GNU General public license" text was a different construction and only redirecting to the top level About page so this adds that as a redirect to the licensing page too.