Issue209 #222
Merged
Issue209 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… model. This way, we can check whether a user-defined keyword (e.g., the steps in a pipeline) does not shadow a model parameter
mfeurer
requested changes
Apr 11, 2017
openml/flows/sklearn_converter.py
Outdated
| if isinstance(o, tuple): | ||
| assert(parent_model is not None) |
There was a problem hiding this comment.
I think this checks should live in _extract_information_from_model as this function only distributes objects to the right serialization functions.
tests/test_flows/test_sklearn.py
Outdated
| for case in cases: | ||
| self.assertRaises(PyOpenMLError, sklearn_to_flow, case) | ||
|
|
||
| def test_illegal_parameter_names_sklearn(self): |
There was a problem hiding this comment.
Could you repeat this test for FeatureUnion.
mfeurer
approved these changes
Apr 11, 2017
Codecov Report
@@ Coverage Diff @@
## develop #222 +/- ##
===========================================
- Coverage 88.88% 88.82% -0.07%
===========================================
Files 23 23
Lines 1800 1807 +7
===========================================
+ Hits 1600 1605 +5
- Misses 200 202 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209. Prevents users from spoofing parameter names