Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the build system and fix CI #68

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Conversation

raimis
Copy link
Contributor

@raimis raimis commented Mar 6, 2023

@raimis raimis self-assigned this Mar 6, 2023
@raimis
Copy link
Contributor Author

raimis commented Mar 29, 2023

@peastman I cannot revive the MacOS tests. The is an issue with OpenCL tests and I cannot fix it. Any ideas about how to fix?

@peastman
Copy link
Member

We shouldn't be installing pocl on Mac. There's no need, since OpenCL is built into the OS. The first thing I'd try is removing it.

@raimis
Copy link
Contributor Author

raimis commented Apr 24, 2023

@peastman I have remove pocl for MacOS, but now the OpenCL test fail because

exception: No compatible OpenCL platform is available

@peastman
Copy link
Member

Do you know what kind of GPU the runner has? Perhaps it's configured in a way that prevents it from accessing the GPU?

When running OpenMM CI builds on Mac, we build the OpenCL platform but don't run any tests for it. I don't remember why. Possibly it was for the same reason?

@raimis raimis changed the title Fix CI Update the build system and fix CI Apr 25, 2023
@raimis raimis marked this pull request as ready for review April 25, 2023 12:54
@raimis raimis requested a review from peastman April 25, 2023 12:55
@raimis
Copy link
Contributor Author

raimis commented Apr 25, 2023

I have disabled the OpenCL test on MacOS. I have no experience with MacOS to fix that.

@raimis
Copy link
Contributor Author

raimis commented Apr 25, 2023

@peastman could you review?

@peastman
Copy link
Member

With OpenMM plugins, we generally don't want to pin the builds to a particular OpenMM version. Every release of the plugin is designed to work with one particular OpenMM release. We don't try to maintain compatibility with older releases, which often isn't possible. And if a new OpenMM release breaks compatibility, we want CI builds of the plugin to start failing immediately so we know we need to update it.

@raimis
Copy link
Contributor Author

raimis commented May 5, 2023

Ideally, we should build tests against the night builds (if ones still exist) of OpenMM. If we notice an incompatibility after the next OpenMM release, it is a bit too late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants