Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update auth library #12

Merged
merged 2 commits into from
May 18, 2023
Merged

Update auth library #12

merged 2 commits into from
May 18, 2023

Conversation

HectorNarvaez
Copy link
Contributor

Updated omh auth library

This was referenced May 16, 2023
Merged
Merged
Anwera64
Anwera64 approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@Anwera64 Anwera64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Look into if you will need the Builder pattern for the client or if you can just remove it.

@HectorNarvaez HectorNarvaez merged commit fbdc1aa into develop May 18, 2023
2 checks passed
@HectorNarvaez HectorNarvaez deleted the state/updateAuthLibrary branch May 18, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anwera64 Anwera64 Anwera64 approved these changes

@wilsoncastiblanco wilsoncastiblanco Awaiting requested review from wilsoncastiblanco

@jdiegoh3 jdiegoh3 Awaiting requested review from jdiegoh3

@hans-hamel hans-hamel Awaiting requested review from hans-hamel

@bardur-encora bardur-encora Awaiting requested review from bardur-encora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HectorNarvaez @Anwera64