List Files Folders #7
Conversation
HectorNarvaez
requested review from
wilsoncastiblanco,
jdiegoh3,
Anwera64,
hans-hamel and
bardur-encora
|
Could you divide this into smaller commits with less files to review, please? Maybe you could create a PR only for the Auth library integration first. |
| setContentView(binding.root) | ||
| binding.recvEmptyView.root.visibility = View.VISIBLE | ||
| /* |
There was a problem hiding this comment.
Is it required to keep the code commented?
|
|
||
| private fun prepareViews() { | ||
| tvSortByName.setOnClickListener { | ||
| // viewModel.sortByName() |
There was a problem hiding this comment.
Same here. Is it required to keep the code commented?
| null -> return@launch | ||
| else -> error("Unsupported credential type") | ||
| } | ||
| /* |
There was a problem hiding this comment.
Same here. Is it required to keep the code commented?
| @@ -18,6 +20,8 @@ class ActivitySplash : AppCompatActivity() { | |||
| @Inject | |||
| lateinit var omhAuthClient: OmhAuthClient | |||
|
|
|||
| // @Inject lateinit var omhStorageClient: OmhStorageClient | |||
There was a problem hiding this comment.
Same here. Is it required to keep the code commented?
| item.name, | ||
| item.extension, | ||
| SimpleDateFormat(RESPONSE_DATE_FORMAT, Locale.ENGLISH).format(item.modificationDate) | ||
| //item.lastModDate.toString() |
There was a problem hiding this comment.
Same here. Is it required to keep the code commented?
| RESPONSE_DATE_FORMAT, | ||
| Locale.ENGLISH | ||
| ).format(item.modificationDate * 1000L) | ||
| //item.lastModDate.toString() |
There was a problem hiding this comment.
Same here. Is it required to keep the code commented?
HectorNarvaez
force-pushed
the
state/listfilesfolders
branch
from
33875c5
to
63b7ac6
Compare
|
@hans-hamel for now, for avoid conflicts i prefer to keep on this PR the code as is right now. I can send another PR later (probably #12) removing the commented code or remove it when i start working on the sample app c.c.: @Anwera64 |
storage-sample/src/main/java/com/omh/android/storage/sample/di/SingletonModule.kt
Show resolved
Hide resolved
This PR includes the latest changes @nelsonfertica let regarding to retrieve the list of files and folders in the remote source.
The idea with this PR is to have main branch updated for start uploading new changes from there