UI update a file #63
Merged
UI update a file #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hans-hamel
added
Don't merge
hans-hamel
requested review from
wilsoncastiblanco,
jdiegoh3,
Anwera64 and
HectorNarvaez
...src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerViewModel.kt
Outdated
Show resolved
Hide resolved
...src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerViewModel.kt
Outdated
Show resolved
Hide resolved
hans-hamel
force-pushed
the
state/updateNonGms
branch
from
c5aa49b
to
feb0578
Compare
hans-hamel
force-pushed
the
state/uiUpdateFile
branch
from
679d96a
to
72e73d1
Compare
hans-hamel
force-pushed
the
state/uiUpdateFile
branch
2 times, most recently
from
4f8e7bb
to
addb88f
Compare
HectorNarvaez
removed
Don't merge
HectorNarvaez
force-pushed
the
state/uiUpdateFile
branch
from
addb88f
to
36a1682
Compare
HectorNarvaez
suggested changes
Jul 5, 2023
Anwera64
approved these changes
Jul 5, 2023
hans-hamel
force-pushed
the
state/uiUpdateFile
branch
from
95b9776
to
bc270c7
Compare
.../src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerActivity.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerActivity.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerActivity.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerActivity.kt
Outdated
Show resolved
Hide resolved
| @@ -55,8 +55,10 @@ class FileViewerViewModel @Inject constructor( | |||
| is FileViewerViewEvent.CreateFile -> createFileEvent(event) | |||
| is FileViewerViewEvent.DeleteFile -> deleteFileEvent(event) | |||
| is FileViewerViewEvent.UploadFile -> uploadFile(event) | |||
| is FileViewerViewEvent.UpdateFile -> updateFile(event) | |||
There was a problem hiding this comment.
please move this below is FileViewerViewEvent.UpdateFileClicked -> updateFileClicked(event) (line 61)
There was a problem hiding this comment.
why is neccesary to move below?
| @@ -110,14 +112,14 @@ class FileViewerViewModel @Inject constructor( | |||
| } | |||
|
|
|||
| private fun downloadFileEvent() { | |||
| setState(FileViewerViewState.Loading) | |||
There was a problem hiding this comment.
why we moved this?
user should see a loading screen once we start to execute any logic
There was a problem hiding this comment.
Because if the file is not downloadable, the file will not be downloadable then the loading state won't be dismissed
There was a problem hiding this comment.
we can dismiss it dispatching a refresh event:
setState(FileViewerViewState.Loading)
if (!file.isDownloadable()) {
toastMessage.postValue("${file.name} is not downloadable")
refreshFileListEvent()
return
}
| private fun updateFile(event: FileViewerViewEvent.UpdateFile) { | ||
| val fileId = lastFileClicked?.id ?: return | ||
|
|
||
| setState(FileViewerViewState.Loading) |
There was a problem hiding this comment.
please move this below method declaration
There was a problem hiding this comment.
If you move below the method declaration, the state loading will be there if the lastFileClicked is null
There was a problem hiding this comment.
same as above, call refresh method
...src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerViewModel.kt
Outdated
Show resolved
Hide resolved
| @@ -137,6 +139,35 @@ class FileViewerViewModel @Inject constructor( | |||
| } | |||
| } | |||
|
|
|||
| private fun updateFile(event: FileViewerViewEvent.UpdateFile) { | |||
There was a problem hiding this comment.
please rename this as updateFileEvent
...src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerViewState.kt
Outdated
Show resolved
Hide resolved
HectorNarvaez
force-pushed
the
state/uiUpdateFile
branch
from
bc270c7
to
53c92a6
Compare
HectorNarvaez
force-pushed
the
state/uiUpdateFile
branch
from
53c92a6
to
4e835c8
Compare
HectorNarvaez
approved these changes
Jul 5, 2023
...src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerViewEvent.kt
Outdated
Show resolved
Hide resolved
| @@ -110,14 +112,14 @@ class FileViewerViewModel @Inject constructor( | |||
| } | |||
|
|
|||
| private fun downloadFileEvent() { | |||
| setState(FileViewerViewState.Loading) | |||
There was a problem hiding this comment.
we can dismiss it dispatching a refresh event:
setState(FileViewerViewState.Loading)
if (!file.isDownloadable()) {
toastMessage.postValue("${file.name} is not downloadable")
refreshFileListEvent()
return
}
| private fun updateFile(event: FileViewerViewEvent.UpdateFile) { | ||
| val fileId = lastFileClicked?.id ?: return | ||
|
|
||
| setState(FileViewerViewState.Loading) |
There was a problem hiding this comment.
same as above, call refresh method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR #61. Once the 'state/updateNonGms' branch is merged, change the base base branch to 'develop'.
Implement the UI to update a file.
ui-upload-file.mov