Ubuntu transition #76
Conversation
There was a problem hiding this comment.
Reviewed 30 of 30 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @brosenberg42)
cpp/motion/SubsenseMotionDetection/StreamingMotionDetection_Subsense.cpp, line 60 at r1 (raw file):
config_.n_samples_for_moving_avgs) { if (config_.verbose > 0) { motion_logger_->setLevel(log4cxx::Level::getDebug());
In general, it seems like you're trying to remove how verbose can be used to set to the log level. Did you keep this one because it's streaming?
cpp/motion/SubsenseMotionDetection/SubSense/bgfg_segm.cpp, line 4 at r1 (raw file):
// minimalistic foreground-background segmentation sample, based off OpenCV's bgfg_segm sample /*
Did you leave this here for reference? If so, let's leave a comment stating that. Without a comment explaining what it is, this just looks like dead code.
cpp/motion/SubsenseMotionDetection/SubsenseUtils.cpp, line 41 at r1 (raw file):
using DetectionComponentUtils::GetProperty; SubsenseConfig::SubsenseConfig(const std::map<std::string, std::string> &props)
Please remove mpfSubsenseMotionDetection.ini and the parent dir openmpf-contrib-components/cpp/motion/SubsenseMotionDetection/plugin-files/config.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @jrobble)
cpp/motion/SubsenseMotionDetection/StreamingMotionDetection_Subsense.cpp, line 60 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
In general, it seems like you're trying to remove how verbose can be used to set to the log level. Did you keep this one because it's streaming?
Yes. The streaming component executor does not handle the LOG_LEVEL environment variable.
cpp/motion/SubsenseMotionDetection/SubSense/bgfg_segm.cpp, line 4 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
Did you leave this here for reference? If so, let's leave a comment stating that. Without a comment explaining what it is, this just looks like dead code.
Previously, this was not compiling
cpp/motion/SubsenseMotionDetection/SubsenseUtils.cpp, line 41 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
Please remove
mpfSubsenseMotionDetection.iniand the parent diropenmpf-contrib-components/cpp/motion/SubsenseMotionDetection/plugin-files/config.
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)
Issues:
Related PRs:
This change is