Add trigger guide #171
Add trigger guide #171
Conversation
There was a problem hiding this comment.
Reviewed 29 of 32 files at r1, 41 of 41 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)
There was a problem hiding this comment.
Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 15 of 15 files at r4, all commit messages.
Reviewable status:
Fix typos.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)
a discussion (no related file):
Please remove the GetDetectionType() from the SDK docs. Also, trackType needs to be added to "Component Descriptor Reference".
There was a problem hiding this comment.
Reviewed 5 of 5 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)
There was a problem hiding this comment.
Reviewable status: 35 of 50 files reviewed, 1 unresolved discussion (waiting on @brosenberg42 and @jrobble)
a discussion (no related file):
Previously, jrobble (Jeff Robble) wrote…
Please remove the
GetDetectionType()from the SDK docs. Also,trackTypeneeds to be added to "Component Descriptor Reference".
Done.
There was a problem hiding this comment.
Reviewed 15 of 15 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)
docs/docs/Trigger-Guide.md line 188 at r7 (raw file):
that will later satisfy the trigger for stage 4. Also, note that stages 1, 2, and 3 can all accept an optional `WHITELIST_FILE` property that can be
This section will need to be changed to "approved list" once your other PR lands. I will leave a comment on that.
Issues:
Related PRs:
This change is