Made named list full screen #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djazayeri
reviewed
May 17, 2017
| @@ -27,16 +27,13 @@ export default class NamedList extends Component { | |||
| const COLUMNS_IF_SIZE = 5; | |||
There was a problem hiding this comment.
Please also delete this, as well as the "half" function above. These are no longer used, right?
There was a problem hiding this comment.
Sorry , don't know why I forgot about that. I've deleted that as well .
There was a problem hiding this comment.
I meant also delete the line const COLUMNS_IF_SIZE = 5;
There was a problem hiding this comment.
Spare me if I still have missed something. Haven't really had much time due to the exams 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Named list is now full screen based on community feedback (Currently still to be decided but in case we choose this route then we can merge this PR)