Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made named list full screen #12

Merged
merged 4 commits into from May 19, 2017
Merged

Made named list full screen #12

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0cd485c
Made named list full screen
reubenvarghese1 May 17, 2017
f754e45
Deleted an extra function with no functional use
reubenvarghese1 May 17, 2017
5224eaf
Update NamedList.jsx
reubenvarghese1 May 18, 2017
ea4975a
Deleted unused variable
reubenvarghese1 May 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/main/ui/app/component/NamedList.jsx
View file
Open in desktop
Expand Up @@ -27,16 +27,13 @@ export default class NamedList extends Component {
const COLUMNS_IF_SIZE = 5;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also delete this, as well as the "half" function above. These are no longer used, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry , don't know why I forgot about that. I've deleted that as well .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant also delete the line const COLUMNS_IF_SIZE = 5;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spare me if I still have missed something. Haven't really had much time due to the exams 😉


const list = this.props.list;
const colSize = list.addOns.length > COLUMNS_IF_SIZE ?
"col-md-6 col-sm-12 col-xs-12" :
"col-md-12 col-sm-12 col-xs-12";

return (
<div>
<h1>{list.name}</h1>
<h3>{list.description}</h3>
<div className="row">
<div className={colSize}>
<div className="col-md-12 col-sm-12 col-xs-12">
{ list.addOns.map(addon => this.display(addon)) }
</div>
</div>
Expand Down