Linked About page #13
Conversation
| @@ -3833,6 +3833,13 @@ | |||
| } | |||
|
|
|||
| ] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Don't put this here. We should not hackily add a "list" that is not actually a list.
| @@ -14,7 +14,7 @@ export default class ListOfLists extends Component { | |||
| } | |||
|
|
|||
| render() { | |||
| const LISTS_TO_SHOW = 3; | |||
| const LISTS_TO_SHOW = 4; | |||
| @@ -25,7 +25,7 @@ export default class ListOfLists extends Component { | |||
| <ul className="nav nav-pills"> | |||
| {toShow.map(list => | |||
| <li className={list.uid === selectedUid ? "active" : ""}> | |||
| <Link to={`/list/${list.uid}`}> | |||
| <Link to={list.name.toString() === "About" ? `/About` : `/list/${list.uid}`}> | |||
There was a problem hiding this comment.
Don't do this. It makes the code look hacky to special-case this.
Ideally we'd add the About link outside of this component (since it doesn't strictly belong in ListOfLists), but it's okay to just put another li element after the More Lists thing. E.g. it's okay to have:
- List 1
- List 2
- List 3
- ...
- About
| a) Bintray <br/> | ||
| b) Modulus <br/> | ||
| <br/> | ||
| Currently we only support these 2 servers but in the future we sure will add more based on user demand! Currently, we are working on adding support for Github Releases as well! |
There was a problem hiding this comment.
This line is too much information. :-)
Instead, in the contributing section below, let's add a link like "Discuss how this tool works and/or propose new features at (link)". And that should link to the new Talk category that I'm suggesting at https://talk.openmrs.org/t/create-a-category-for-the-add-on-index-project/11700
| <p> Adding your module to Add Ons for indexing is as easy as creating a pull request! | ||
| Before we do that, we need to ensure that your module has been hosted on one of the sites that Add Ons currently supports indexing from: <br/> | ||
| a) Bintray <br/> | ||
| b) Modulus <br/> |
There was a problem hiding this comment.
Instead of Modulus, call this "modules.openmrs.org".
(Technically Modulus is the name of the underlying software, not the tool we have running.)
| <a target="_blank" | ||
| href="https://github.com/djazayeri/openmrs-contrib-addonindex/blob/master/README.md">Read more on | ||
| GitHub</a> | ||
| <h3>2)How to contribute to Add Ons development?</h3> |
There was a problem hiding this comment.
I suggest rephrasing this as "About the OpenMRS Add Ons tool"
It can have links to:
- Discussion forum (e.g. the new talk category I mentioned above)
- Contribute to the code (e.g. the contributing link)
- License (as mentioned by Robby here https://talk.openmrs.org/t/replacing-modulus-design-thoughts/9619/44)
- Note that we need to add a license before we go live. Whoops!
| </div> | ||
|
|
||
| <h3>Addons Stats:</h3> | ||
| <div> |
There was a problem hiding this comment.
For consistency:
- This should be
<p>instead of<div>like in the other two sections. - For the other two sections, get rid of the 1) and 2)
| @@ -121,8 +121,10 @@ public void testModuleBackendDetails() throws Exception { | |||
| @Test | |||
| public void testListsHaveNames() throws Exception { | |||
| for (AddOnList list : toIndex.getLists()) { | |||
| if (!list.getName().toString().equals("About")){ | |||
There was a problem hiding this comment.
Get rid of this, this is hacky. :-)
|
Closing this PR and creating a new one which links to Jira |
Linked about page and also added use information as planned