AC-1027: Migrate ActiveVisits package from MVP to MVVM architecture #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrsalah3
force-pushed
the
AC-1027
branch
3 times, most recently
from
c571e9c
to
ea2ddb0
Compare
Rohit-2602
approved these changes
Jul 8, 2022
|
I am not conversant with the project so @Rohit-2602 feel free to merge when the commits meet the ticket requirement. BTW is @LuGO0 on ground? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
I've Migrated ActiveVisits package from MVP to MVVM architecture. This PR combines the previous PR into it (947)(AC-1029).
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-1027
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)