Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RATEST-351: Add automated webdriver management #489

Merged
merged 4 commits into from Jun 13, 2023
Merged

RATEST-351: Add automated webdriver management #489

merged 4 commits into from Jun 13, 2023

Conversation

Piumal1999
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • I have tested the changes locally and verified that they work as intended.
  • I have added comments to my code where necessary to help others understand my changes.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

In the contrib-qa-framework, currently, we have to manually update the browser drivers whenever a new version of the drivers (Chrome/Gecko) is released. However, we can improve this process by configuring Selenium to automatically retrieve the appropriate web driver during test execution.

By implementing this change, we can enjoy the following benefits:

  • Elimination of the need to store the drivers in the repository.
  • Removal of the manual update requirement for the drivers.
  • Streamlined test execution for developers, as they no longer have to search for drivers compatible with their operating system and browser.

Screenshots

None.

Related Issue

https://issues.openmrs.org/projects/RATEST/issues/RATEST-351

Other

None.

@Piumal1999 Piumal1999 marked this pull request as ready for review June 5, 2023 15:23
@Piumal1999 Piumal1999 marked this pull request as draft June 5, 2023 15:40
@Piumal1999 Piumal1999 marked this pull request as ready for review June 5, 2023 17:52
jayasanka-sack
jayasanka-sack approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Piumal1999 !

@jayasanka-sack jayasanka-sack merged commit d482308 into openmrs:master Jun 13, 2023
56 checks passed
@kdaud
Copy link
Member

kdaud commented Jun 13, 2023

Hi @Piumal1999, did you take a look at the build failures when the changes entered the master branch?

@Piumal1999
Copy link
Collaborator Author

Hi @Piumal1999, did you take a look at the build failures when the changes entered the master branch?

Seems like it fails to download node and npm in some workflows. I'll further look into this.

Piumal1999 added a commit to Piumal1999/openmrs-contrib-qaframework that referenced this pull request Jun 14, 2023
@Piumal1999
Ratest 352 (#3)
f9cddd3 
* RATEST-350: Remove duplicate OCL module test (openmrs#486)

* RATEST-350: Remove duplicate ocl module test and cypress

* Update README file

* Remove unwanted dependency

* RATEST-351: Add automated webdriver management (openmrs#489)

* RATEST-351: Add automated webdrivers

* Add EOF

* Update node and npm to LTS versions

* RATEST-352: Bump node version to 16.20.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayasanka-sack jayasanka-sack jayasanka-sack approved these changes

@kdaud kdaud Awaiting requested review from kdaud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Piumal1999 @kdaud @jayasanka-sack