RATEST-192: Implement the Clinical Visit workflow #72
Conversation
jayasanka-sack
force-pushed
the
RATEST-192
branch
3 times, most recently
from
e1894d4
to
7162f50
Compare
| # Scenario: The Attachments page should function properly | ||
| # When the user clicks on the "Attachments" menu | ||
| # Then the attachments list should be empty | ||
| # When the user adds an attachment | ||
| # Then the added attachment should be listed |
There was a problem hiding this comment.
The attachment page won't get loaded in cypress. (Tested with both chrome and electron)
Will create an issue for this.
There was a problem hiding this comment.
We main need to add a waiter instance to wait for the page to load. Some pages takes longer to load!
There was a problem hiding this comment.
This seems a bug. It never loads (only the attachment chart. the rest of the items in the attachment page loadfine).
Reported here:
https://issues.openmrs.org/browse/MF-728
| # Scenario: The Encounters page should function properly | ||
| # When the user clicks on the "Encounters" menu | ||
| # Then the notes list should be empty | ||
| # When the user adds a note |
There was a problem hiding this comment.
It throws 500 when running it with Cypress. (Tested with both chrome and electron)
Works fine when accessing with a normal browser.
There was a problem hiding this comment.
It throws 500 when running it with Cypress. (Tested with both chrome and electron)
Share the logs here via pastebin.com
There was a problem hiding this comment.
Reported here:
https://issues.openmrs.org/browse/MF-727
jayasanka-sack
force-pushed
the
RATEST-192
branch
from
7162f50
to
a5a3aa8
Compare
cypress/integration/cucumber/step_definitions/refapp-3.x/04-visit/visit.js
Outdated
Show resolved
Hide resolved
jayasanka-sack
force-pushed
the
RATEST-192
branch
from
46a4953
to
cb6010e
Compare
|
Hi @jayasanka-sack , should I review this now, or wait until it's out of draft? |
|
Hi @brandones, It's ready to be merged. Other scenarios cannot be completed because there are several bugs. I reported them here: May I keep the commented steps on the feature file or remove them? |
For future follow implementation of the respective user stories, keeping the steps commented overrides removing them! |
cypress/integration/cucumber/step_definitions/refapp-3.x/04-clinical-visit/clinical-visit.js
Outdated
Show resolved
Hide resolved
src/test/resources/features/refapp-3.x/04-clinical-visit/clinical-visit.feature
Outdated
Show resolved
Hide resolved
cypress/integration/cucumber/step_definitions/refapp-3.x/04-clinical-visit/clinical-visit.js
Outdated
Show resolved
Hide resolved
| body: { | ||
| patient: patientUuid, | ||
| startDatetime: new Date().toISOString(), | ||
| visitType: "7b0f5697-27e3-40c4-8bae-f4049abfb4ed", |
There was a problem hiding this comment.
What's this visit type? Could you add the name in an inline comment?
|
Thanks @brandones, btw, we need to fix the pation deletion issue. (only on this workflow) Otherwise, it will continue to create "John Doe"s |
|
Yes, that would be great! Is there a ticket for that? Are you working on it? |
* RATEST-192: Implement the Clinical Visit workflow * Rename 'visit' with 'clinical-visit' * Fix formatting issues * Add minor fixes Co-authored-by: Brandon Istenes <bistenes@gmail.com>
Purpose
The purpose of this PR is to fix: https://issues.openmrs.org/projects/RATEST/issues/RATEST-192
Goals
To give users confidence that the Clinical visit workflow of the RefApp 3.x is working as expected.
Approach
Workflow Case
https://docs.google.com/document/d/1fvq0DH3NJSCxThe1jYlv3TqbvgW7OO3QswYQcocbHiM/edit#heading=h.xwhmkk9rj7rs