Provide configuration setting that can allow turning off validation in Save Handlers - TRUNK-3708 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save Handlers - TRUNK-3708
setting that can allow turning off validation in Save Handlers - TRUNK-3708
dkayiwa
added a commit
that referenced
this pull request
Nov 14, 2012
Provide configuration setting that can allow turning off validation in Save Handlers - TRUNK-3708
| if (s == null) | ||
| return defaultValue; | ||
| return s; | ||
| //Disable automatic flushing which happens in some cases when this method is called. |
There was a problem hiding this comment.
I don't think we want to do this. Validation should be already done in the manual flush mode. If there were places where it failed, it means a validator was used directly, whereas ValidationUtil should have been used instead.
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
…er tools (openmrs#113) Co-authored-by: Donald Kibet <chelashawddonald@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide configuration setting that can allow turning off validation in Save Handlers - TRUNK-3708