TRUNK-4869: added deathDate validation if it is set in future. BirthD… #1857
Conversation
|
@samshuster, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bmamlin and @suniala to be potential reviewers. |
samshuster
force-pushed
the
TRUNK-4869
branch
from
7ac06ed
to
8a25aa0
Compare
|
first pull request for this project. I think i followed all directions! |
| @@ -166,8 +185,7 @@ public void validate_shouldFailValidationIfFieldLengthsAreNotCorrect() throws Ex | |||
| person.setBirthdate(new Date()); | |||
| person.setGender("too long text too long too long text too long text too long text"); | |||
| person.setPersonVoided(true); | |||
| person | |||
There was a problem hiding this comment.
Did you touch this? Or did you forget to run mvn clean install before committing as advised at https://wiki.openmrs.org/display/docs/Pull+Request+Tips
There was a problem hiding this comment.
I ran the formatter on the whole file and it removed the new line here from a previous commit. You are right though that it has nothing to do with my changes. Should I only run formatting on the blocks that I add?
There was a problem hiding this comment.
We only recommend doing mvn clean install on the whole project. This should not have any formatting in places you have not touched.
…ate validation already existed TRUNK-4869: added javadocs to all methods. Fixed naming TRUNK-4869: fixing formatting removing formatting to unrelated changes
samshuster
force-pushed
the
TRUNK-4869
branch
from
8a25aa0
to
2ffdf76
Compare
|
I see thanks for your patience @dkayiwa. I removed the formatting change that was introduced by accident. I made sure the project builds with a mvn clean install. |
Description
Related Issue
see https://issues.openmrs.org/browse/TRUNK-
Checklist:
git pull --rebase upstream master.mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
…ate validation already existed
TRUNK-4869: added javadocs to all methods. Fixed naming