TRUNK-4957: Removed code duplication in OpenmrsUtil class #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lkukielka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bmamlin, @dkayiwa and @suniala to be potential reviewers. |
rkorytkowski
requested changes
Nov 3, 2016
| filepath = OpenmrsConstants.APPLICATION_DATA_DIRECTORY_FALLBACK_WIN + File.separator + "OpenMRS"; | ||
| } | ||
| filepath = System.getProperty("user.home") + File.separator + "Application Data" + File.separator | ||
| + "OpenMRS"; |
There was a problem hiding this comment.
Note the filepath differs for unix based system
There was a problem hiding this comment.
The duplication was https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/util/OpenmrsUtil.java#L1055-L1069 and not what you removed.
There was a problem hiding this comment.
Nevermind, misread the code. All good.
rkorytkowski
approved these changes
Nov 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
see https://issues.openmrs.org/browse/TRUNK-4957
Checklist:
git pull --rebase upstream master.mvn clean packageright before creating this pull request andadded all formatting changes to my commit.