Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-4839: Exposing Patient Search Options Via UI #1871

Merged
merged 1 commit into from
Nov 16, 2016
Merged

TRUNK-4839: Exposing Patient Search Options Via UI #1871

merged 1 commit into from
Nov 16, 2016

Conversation

Nishen-Peiris
Copy link

Description

Add @param annotations to below methods of org.openmrs.api.db.hibernate.HibernatePatientDAO.java
01.getPatient
02.savePatient
03.getDuplicatePatientsByAttributes
04.getPatientIdentifier
05.savePatientIdentifier
06.getCountOfPatients
07.getCountOfPatients
08.getAllPatients(boolean)

Add @return annotations to below methods of org.openmrs.api.db.hibernate.HibernatePatientDAO.java
01.getPatient
02.savePatient
03.getDuplicatePatientsByAttributes
04.getPatientIdentifier
05.savePatientIdentifier
06.getCountOfPatients
07.getCountOfPatients
08getAllPatients(boolean)

Related Issue

I haven't implemented the feature completely.
see https://issues.openmrs.org/browse/TRUNK-4839

Checklist:

  • My pull request only contains one single commit.
  • My pull request is based on the latest master branch
    git pull --rebase upstream master.
  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.
  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

….db.hibernate.HibernatePatientDAO.java
@mention-bot
Copy link

@Nishen-Peiris, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bmamlin, @karrtikiyer-tw and @jdegraft to be potential reviewers.

@dkayiwa dkayiwa merged commit e037b58 into openmrs:master Nov 16, 2016
@dkayiwa
Copy link
Member

dkayiwa commented Nov 16, 2016

Thanks @Nishen-Peiris :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 55.706% when pulling b899e4f on Nishen-Peiris:TRUNK-4839 into d7228cb on openmrs:master.

@Nishen-Peiris
Copy link
Author

You are welcome @dkayiwa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants