Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove TODO from the addAttribute() method on the files concept.jav, … #1881

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

fanyui
Copy link
Contributor

@fanyui fanyui commented Dec 1, 2016

TRUNK-4923

Description

Remove TODO from the addAttribute() method on the files concept.java, BaseCustomizableData.java, BaseCustomizableMetadata.java"

Related Issue

see https://issues.openmrs.org/browse/TRUNK-4923

Checklist:

  • My pull request only contains one single commit.
  • My pull request is based on the latest master branch
    git pull --rebase upstream master.
  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.
  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…BaseCustomizableData.java,BaseCustomizableMetadata.java

@mention-bot
Copy link

@fanyui, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bmamlin, @chethandeshpande and @suniala to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 55.706% when pulling 5afe354 on fanyui:TRUNCK-4923 into 4dc0e2c on openmrs:master.

…BaseCustomizableData.java,BaseCustomizableMetadata.java
@dkayiwa dkayiwa merged commit 179938b into openmrs:master Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants