Trunck 4975 Making Family name as Optional #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fanyui, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bmamlin, @suniala and @ShekharReddy4 to be potential reviewers. |
|
@fanyui did you notice the travis failure? |
|
@dkayiwa I have not noticed an error as it builds without errors or maybe
am looking for the errors at the wrong place. I will appreciate pointers
on how to find the said error.
…On Thu, Dec 8, 2016 at 7:23 PM, dkayiwa ***@***.***> wrote:
@fanyui <https://github.com/fanyui> did you notice the travis failure?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1887 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALxk5UqfliP_tme_P4_M4Q0VD8LnZ2TLks5rGFkVgaJpZM4LIIMc>
.
|
|
Can you squash the commits into one as per https://wiki.openmrs.org/display/docs/Pull+Request+Tips? |
|
@fanyui did you get a chance to test this out in a running web application to confirm that you can now register patients with only the given name? |
|
@dkayiwa Yes i did using the mvn jetty:run command and it worked.
…On Fri, Dec 9, 2016 at 12:59 PM, dkayiwa ***@***.***> wrote:
@fanyui <https://github.com/fanyui> did you get a chance to test this out
in a running web application to confirm that you can now register patients
with only the given name?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1887 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALxk5WGdbqF88JDRihDQKshtsR30zyePks5rGVCXgaJpZM4LIIMc>
.
|
|
The interface still has the field marked as required though it is not
really required
On Sat, Dec 10, 2016 at 6:31 AM, Harisu fanyui <fanyuiharisu@gmail.com>
wrote:
… @dkayiwa Yes i did using the mvn jetty:run command and it worked.
On Fri, Dec 9, 2016 at 12:59 PM, dkayiwa ***@***.***> wrote:
> @fanyui <https://github.com/fanyui> did you get a chance to test this
> out in a running web application to confirm that you can now register
> patients with only the given name?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1887 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ALxk5WGdbqF88JDRihDQKshtsR30zyePks5rGVCXgaJpZM4LIIMc>
> .
>
|
|
@fanyui instead of removing these tests, can you instead make them test the opposite? For instance, if a test says "should fail if familyName is blank", you could make it, "should pass if familyName is blank". |
… corresponding error message in messages.properties file also modified Some of the tests carried out on familyName to reflect the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I Removed the validation carried out on familyName
and also change the message.properties file to give a message that best resemble the error.
I also remove the tests that are carried out on the patientName when you compile the project
Related Issue
see https://issues.openmrs.org/browse/TRUNK-4975
Checklist:
git pull --rebase upstream master.mvn clean packageright before creating this pull request andadded all formatting changes to my commit.