TRUNK-4935: Removed TODO line at Line 459 of ProgramWorkflowService.java #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tendomatGitHub the only line to be removed was the one having the TODO. |
|
aah what a mess so ill do it again from the master branch |
|
aah trouble ill try to change again
…On Mon, Dec 12, 2016 at 9:35 PM, dkayiwa ***@***.***> wrote:
@tendomatGitHub <https://github.com/tendomatGitHub> the only line to be
removed was the one having the TODO.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1891 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APi9StJl8vFRCmxx6BBfk-eK7KraXK4Xks5rHZQLgaJpZM4LKq2k>
.
|
|
Can you squash these commits into one as advised at? https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
|
Alright let me see how to do that shortly
…On Tue, Dec 13, 2016 at 12:15 PM, Coveralls ***@***.***> wrote:
[image: Coverage Status] <https://coveralls.io/builds/9253244>
Coverage increased (+0.009%) to 55.798% when pulling *6adab3b
<6adab3b>
on tendomatGitHub:TRUNK-4935* into *8268091
<8268091>
on openmrs:master*.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1891 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APi9SgOz4XdLCh_i9DsbDlVpwCLFRgMWks5rHmJOgaJpZM4LKq2k>
.
|
|
let me go for my next challenge
…On Tue, Dec 13, 2016 at 12:21 PM, tendo martyn ***@***.***> wrote:
Alright let me see how to do that shortly
On Tue, Dec 13, 2016 at 12:15 PM, Coveralls ***@***.***>
wrote:
> [image: Coverage Status] <https://coveralls.io/builds/9253244>
>
> Coverage increased (+0.009%) to 55.798% when pulling *6adab3b
> <6adab3b>
> on tendomatGitHub:TRUNK-4935* into *8268091
> <8268091>
> on openmrs:master*.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1891 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/APi9SgOz4XdLCh_i9DsbDlVpwCLFRgMWks5rHmJOgaJpZM4LKq2k>
> .
>
|
|
@tendomatGitHub congs for your first pull request merged. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.openmrs.org/browse/TRUNK-4935
TRUNK-4935: Removed TODO line at Line 459 of ProgramWorkflowService.java
I removed the TODO line at Line 459 of ProgramWorkflowService.java.Please review my work and get back to me thanks