Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-5030 Collection.isEmpty() should be used to test for emptiness #1995

Merged
merged 1 commit into from
Feb 15, 2017
Merged

TRUNK-5030 Collection.isEmpty() should be used to test for emptiness #1995

merged 1 commit into from
Feb 15, 2017

Conversation

reubenvarghese1
Copy link
Contributor

@reubenvarghese1 reubenvarghese1 commented Feb 15, 2017

Description

Replaced all the other ways of checking if size is 0 by using isEmpty() function

Related Issue

see https://issues.openmrs.org/browse/TRUNK-5030

Checklist:

  • My pull request only contains one single commit.
  • My pull request is based on the latest master branch
    git pull --rebase upstream master.
  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.
  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All existing tests passed.

@mention-bot
Copy link

@reubenvarghese1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bmamlin, @suniala and @dkayiwa to be potential reviewers.

@@ -1,4 +1,4 @@
/**
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reubenvarghese1 can you fix the formatting here please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teleivo I wonder why this test is failing now.I had tested the build before creating the PR.I'll look into it and the formatting :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried running that test in my PC and it compiled without any errors , now i'm kinda clueless regarding the error out here.Any ideas?

@teleivo
Copy link
Member

teleivo commented Feb 15, 2017

thanks @reubenvarghese1 👍

@teleivo
Copy link
Member

teleivo commented Feb 15, 2017

@reubenvarghese1 please squash your two commits into one

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 55.725% when pulling 24f555d on reubenvarghese1:master into 6c60380 on openmrs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 55.728% when pulling 221fe59 on reubenvarghese1:master into 6c60380 on openmrs:master.

@reubenvarghese1
Copy link
Contributor Author

reubenvarghese1 commented Feb 15, 2017

@teleivo Squashed the commits .I think we are good to go :-)

@teleivo
Copy link
Member

teleivo commented Feb 15, 2017

@reubenvarghese1 looks good to me, @dkayiwa :)

@dkayiwa
Copy link
Member

dkayiwa commented Feb 15, 2017

Thanks @reubenvarghese1 for working on it and thanks @teleivo for reviewing! 😊

@dkayiwa dkayiwa merged commit 163bb19 into openmrs:master Feb 15, 2017
@teleivo
Copy link
Member

teleivo commented Feb 16, 2017

thank you @reubenvarghese1 technical debt went down :)
see https://ci.openmrs.org/sonar/dashboard/index/1865?did=1

@reubenvarghese1
Copy link
Contributor Author

Anytime @teleivo .I'm glad my contribution was of use :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants