-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRUNK-5030 Collection.isEmpty() should be used to test for emptiness #1995
Conversation
@reubenvarghese1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bmamlin, @suniala and @dkayiwa to be potential reviewers. |
@@ -1,4 +1,4 @@ | |||
/** | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reubenvarghese1 can you fix the formatting here please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teleivo I wonder why this test is failing now.I had tested the build before creating the PR.I'll look into it and the formatting :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried running that test in my PC and it compiled without any errors , now i'm kinda clueless regarding the error out here.Any ideas?
thanks @reubenvarghese1 👍 |
@reubenvarghese1 please squash your two commits into one |
@teleivo Squashed the commits .I think we are good to go :-) |
@reubenvarghese1 looks good to me, @dkayiwa :) |
Thanks @reubenvarghese1 for working on it and thanks @teleivo for reviewing! 😊 |
thank you @reubenvarghese1 technical debt went down :) |
Anytime @teleivo .I'm glad my contribution was of use :-) |
Description
Replaced all the other ways of checking if size is 0 by using isEmpty() function
Related Issue
see https://issues.openmrs.org/browse/TRUNK-5030
Checklist:
git pull --rebase upstream master
.mvn clean package
right before creating this pull request andadded all formatting changes to my commit.