TRUNK-3204 : Add JUnit test for getting by null/true/false isPreferred i... #231
Conversation
| public void getPatientIdentifiers_shouldLimitByResultsByPreferredAndNonPreferredIdentifier() throws Exception { | ||
|
|
||
| List<PatientIdentifier> patientIdentifiers = dao.getPatientIdentifiers(null, new ArrayList<PatientIdentifierType>(), | ||
| new ArrayList<Location>(), new ArrayList<Patient>(), null); |
There was a problem hiding this comment.
What happens here if you pass in null, instead of the empty collections, i think it should be able to work
There was a problem hiding this comment.
Since you are passing in null for the isPreferred argument, i think the test name should mention this, i.e the test name should be something like:
getPatientIdentifiers_shouldReturnAllMatchingNonVoidedPatientIdentifiersIfIsPreferredIsSetToNull()
And preferrably use the behavior test plugin https://wiki.openmrs.org/display/docs/Generate+Test+Case+Plugin to generate these tests
There was a problem hiding this comment.
I saw implementation of HibernatePatienDAO::getPatientIdentifiers. And there is assumption that parameter with type collection is not null ( directly invoke size() method on collection).
There was a problem hiding this comment.
That is right, and it is because in PatientServiceImpl they are set to empty lists if they are null, so you don't have to do it too when calling the method.
…d in HibernatePatientDAO.getPatientIdentifiers TRUNK-3204: Add JUnit test for getting by null/true/false isPreferred in HibernatePatientDAO.getPatientIdentifiers TRUNK-3204: Add JUnit test for getting by null/true/false isPreferred in HibernatePatientDAO.getPatientIdentifiers TRUNK-3204: Add JUnit test for getting by null/true/false isPreferred in HibernatePatientDAO.getPatientIdentifiers
TRUNK-3204 : Add JUnit test for getting by null/true/false isPreferred i...
3 test written based on data in standardTestDatabase.xml file.