TRUNK-3751 #270
Closed
TRUNK-3751 #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -274,12 +276,14 @@ public static boolean matchRequiredVersions(String version, String value) { | |||
| * @should throw ModuleException if required version with wild card on one end beyond openmrs | |||
| * version | |||
| * @should throw ModuleException if single entry required version beyond openmrs version | |||
| * @should throw ModuleException if SNAPSHOT not handled correctly | |||
There was a problem hiding this comment.
Am a little confused by this @should, i thought the aim of the ticket is to make sure it handles SNAPSHOT versions
|
I've sent this on behalf of Andrea. I'm cancelling this as it's being worked on by someone else now. |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.openmrs.org/browse/TRUNK-3751