TRUNK-3974 fix ConceptNumerix(concept) inncorrectly copies collecitions #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you squash these commits into one? |
|
Done,definitely i have to know git better ;/ |
|
|
||
| for (ConceptAnswer cAnswer : cn.getAnswers()) { | ||
| Assert.assertSame(cn, cAnswer.getConcept()); | ||
| Assert.assertNotSame(c, cAnswer.getConcept()); |
There was a problem hiding this comment.
It is pointless to add the second assertion, it can never fail if the first passed because c and cn are already different objects, makes sense?
|
Closing because author abandoned it. |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link to ticket : https://tickets.openmrs.org/browse/TRUNK-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel