Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-5517 Upgrade commons Libraries #3037

Merged

Conversation

Irenyak1
Copy link
Member

Description of what I changed

I Upgraded library commons sub-Libraries as below

1. commons-fileupload:commons-fileupload … 1.3.3  to 1.4
2. commons-io:commons-io … 2.5  to 2.6
3. commons-validator:commons-validator … 1.4.0 to 1.6

Issue I worked on

https://issues.openmrs.org/browse/TRUNK-5517

Checklist: I completed these to help reviewers :)

  • [x ] My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).

    No? -> read here on how to squash multiple commits into one

  • [ x] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [x ] I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • [x ] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • [x ] My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@coveralls
Copy link

coveralls commented Oct 24, 2019

Coverage Status

Coverage increased (+0.01%) to 59.839% when pulling 9cbab3e on Irenyak1:TRUNK-5517-Upgrade-commons-Libraries into 34a42ea on openmrs:master.

@ODORA0
Copy link
Contributor

ODORA0 commented Oct 25, 2019

This looks good enough

@Irenyak1
Copy link
Member Author

Hello @dkayiwa please may you review this pull request when you find time.

@dkayiwa
Copy link
Member

dkayiwa commented Oct 25, 2019

Did you just forget to include the ticket id in the commit message?

@Irenyak1
Copy link
Member Author

oh sure @dkayiwa I forgot. Let me fix it.

@Irenyak1 Irenyak1 force-pushed the TRUNK-5517-Upgrade-commons-Libraries branch from c410791 to 9cbab3e Compare October 28, 2019 07:46
@Irenyak1
Copy link
Member Author

Hello @dkayiwa I have worked on the commit message and I have included the ticket Id. Please may you review my PR when you find time.

@dkayiwa
Copy link
Member

dkayiwa commented Oct 28, 2019

Are these the latest versions available for each of the dependencies?

@Irenyak1
Copy link
Member Author

@dkayiwa ,From my search, yes those are the latest versions available

@dkayiwa
Copy link
Member

dkayiwa commented Oct 28, 2019

@Irenyak1 did you upgrade all the libraries mentioned on the ticket?

@Irenyak1
Copy link
Member Author

@dkayiwa As I commented on the ticket, I did not upgrade "commons-collections:commons-collections … 3.2.2 "
because it was already up to date

@dkayiwa dkayiwa merged commit 4874e66 into openmrs:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants