TRUNK-6013 - Upgrade to Liquibase 4

[ibacher]

TRUNK-6013 - Upgrade to Liquibase 4

Description of what I changed

Upgrades Core to using Liquibase 4. This should resolve the issue mentioned here and allow us to continue updating the MySQL driver.

Tested against both Jetty and Tomcat.

Issue I worked on

Checklist: I completed these to help reviewers :)

• My IDE is configured to follow the code style of this project.

  No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)

  No? -> write tests and add them to this commit git add . && git commit --amend

• I ran mvn clean package right before creating this pull request and
  added all formatting changes to my commit.

  No? -> execute above command

• All new and existing tests passed.

  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

• My pull request is based on the latest changes of the master branch.

  No? Unsure? -> execute command git pull --rebase upstream master

[dkayiwa]

@ibacher wouldn't it be easier to troubleshoot possible problems if you separate these two unrelated upgrades?

[ibacher]

@dkayiwa Sure! I can reduce this to just upgrading Liquibase. I just figured I'd do the MySQL as well since this seemed to be the blocker.

[corneliouzbett]

@ibacher wouldn't it be easier to troubleshoot possible problems if you separate these two unrelated upgrades?

To some extent, there are related. Upgrading liquibase has to happen first. Tried upgrading the MySQL connector, run into this

java.lang.ClassCastException: class java.time.LocalDateTime cannot be cast to class java.lang.String (java.time.LocalDateTime and java.lang.String are in module java.base of loader 'bootstrap')
amrs-upgrade           | 	at liquibase.changelog.StandardChangeLogHistoryService.getRanChangeSets(StandardChangeLogHistoryService.java:328) ~[liquibase-core-3.10.2.jar:?]
amrs-upgrade           | 	at liquibase.changelog.AbstractChangeLogHistoryService.upgradeChecksums(AbstractChangeLogHistoryService.java:66) ~[liquibase-core-3.10.2.jar:?]
amrs-upgrade           | 	at liquibase.changelog.StandardChangeLogHistoryService.upgradeChecksums(StandardChangeLogHistoryService.java:297) ~[liquibase-core-3.10.2.jar:?]

Which call for upgrading liquibase.

[dkayiwa]

The upgrade of liquibase does not require that of mysql connector. But the upgrade of mysql connector requires that of liquibase. So i believe we can do the mysql connector upgrade as a followup in its own pull request. Just like we have done for hibernate and spring. On another note, you raise a very good point that if we had already upgraded liquibase, we would not have had to revert this: #3681 😊

[ibacher]

I missed that we weren't actually loading the Liquibase extensions when doing my testing, so leaving this in draft until I can retest the changes.

[coveralls]

Coverage decreased (-0.1%) to 63.567% when pulling ac147d2 on liquibase_4 into df833f4 on master.

[jonathandick]

@ibacher any updates on this? It seems this a blocker for us at AMPATH as well.

[ibacher]

Ok self review: successfully updated from RefApp 2.12.0-SNAPSHOT on core 2.4.0 -> core 2.5.0 with this change.

[corneliouzbett]

Upgraded successfully!