TRUNK-6202 Replace Hibernate Criteria API with JPA Criteria API for HibernateAdministrationDAO #4449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4pran
force-pushed
the
TRUNK-6201-HibernateAdministrationDAO
branch
2 times, most recently
from
4c5947a
to
22fe074
Compare
…ibernateAdministrationDAO
k4pran
force-pushed
the
TRUNK-6201-HibernateAdministrationDAO
branch
from
22fe074
to
dd9f9b0
Compare
Wandji69
pushed a commit
to Wandji69/openmrs-core
that referenced
this pull request
Mar 29, 2024
…ibernateAdministrationDAO (openmrs#4449)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
I am initiating the migration of the Hibernate Criteria API to the JPA Criteria API, starting with the HibernateAdministrationDAO class. This task represents the first in a series of pull requests aimed at systematically updating our DAOs.
Additionally, I've incorporated several new tests and confirmed their compatibility with the existing Hibernate Criteria implementation. This pre-validation step is to ensure that our transition to the JPA Criteria API is regression-free.
A small change I made was to
shouldHaveTestAnnotationWhenStartingWithShouldto handle tests with theParameterizedTestannotationIssue I worked on
see https://issues.openmrs.org/browse/TRUNK-6202
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master