RATEST-92:Failing Test: Contact Info Test #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaweesi
reviewed
Jun 21, 2021
| import java.util.List; | ||
| import java.util.Optional; |
kaweesi
reviewed
Jun 21, 2021
| @@ -56,7 +54,7 @@ public void contactInfoTest() throws Exception { | |||
| registrationEditSectionPage.clearPhoneNumber(); | |||
| registrationEditSectionPage.enterPhoneNumber("aaaaaaaaa"); | |||
| registrationEditSectionPage.clickOnConfirmEdit(); | |||
| assertTrue(registrationEditSectionPage.getInvalidPhoneNumberNotification().contains("Must be a valid phone number (with +, -, numbers or parentheses)")); | |||
| // assertTrue(registrationEditSectionPage.getInvalidPhoneNumberNotification().contains("Must be a valid phone number (with +, -, numbers or parentheses)")); | |||
There was a problem hiding this comment.
any reason to commenting this? and the code format is wrong too
There was a problem hiding this comment.
Am working on this to resolve the issues with the method reference getInvalidPhoneNumberNotification() which is breaking the test
|
The Fix was done in openmrs/openmrs-contrib-uitestframework#45 , since the element was not the collect one, so am closing this |
|
Untill this bug is fixed with in openmrs/openmrs-contrib-uitestframework#45 (comment) , then this ticket will be able to work as expected, so i fixed two at once cc @k-joseph |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.openmrs.org/browse/RATEST-92
By default this should fail untill we merge this bug fix openmrs/openmrs-contrib-uitestframework#45