(feat) Group Session Visits #37
Conversation
ZacButko
requested review from
manuelroemer,
vasharma05 and
hadijahkyampeire
and removed request for
manuelroemer
| @@ -53,7 +53,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@carbon/react": "^1.9.0", | |||
| "@openmrs/esm-framework": "next", | |||
There was a problem hiding this comment.
Shouldn't this be kept for local purpose only?
There was a problem hiding this comment.
I thought so as well but maybe we need to push the updated version if it won't break stuff, I think everyone needs to point to the right version of openmrs-framework. I will defer to Zac on what is best.
There was a problem hiding this comment.
haha, yes, you are correct
| @@ -259,6 +259,8 @@ const reducer = (state, action) => { | |||
| activeFormUuid: null, | |||
| }; | |||
| persistData(newState); | |||
| //eslint-disable-next-line | |||
There was a problem hiding this comment.
The next line includes a template literal variable syntax in a non template literal string. This throws an eslint error, so the eslint-disable-next-line suppresses it.
The components are sufficiently different that it benefits having two different functions. One has two buttons, the other has three. Each modal calls very specific functions from the context it operates in, really if you were to try to abstract this you would be replicate most logic with two results, so in the end it is much more clear just to have two different components |
Requirements
Summary
This includes many changes but the most important change is that this is now saving a visit for a user when entering the Group Session data. After the visit is created the form data is posted with the new visitUUID attached. In then end when we check the patient's chart we can see their data now shows up on the visit.
Screenshots
GroupSessionVisits.mov
Related Issue
Other