Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bugfix) Prevent Filter Tree Infinite Render #655

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

ZacButko
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

Prevents infinite initialization of Filter context if there is no data

Screenshots

Screen Shot 2022-04-14 at 7 58 08 AM

Related Issue

O3-1202

Other

@ZacButko ZacButko changed the title Bugfix/filter tree infinite render (bugfix) Prevent Filter Tree Infinite Render Apr 14, 2022
@brandones
Copy link
Contributor

LGTM but gotta fix the build

@vasharma05
Copy link
Member

Hi @ZacButko!
Just for my information, why were the changes needed in the esm-form-entry-app?

@ZacButko
Copy link
Contributor Author

@vasharma05 these were the prettier fixes required by lint on push

This reverts commit 26e5368.
@brandones brandones merged commit 2bcaa2b into master Apr 15, 2022
@brandones brandones deleted the bugfix/filter-tree-infinite-render branch April 15, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants