Patient attachments app improvement #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the uploaded files to change name and description
|
@vasharma05 looks reasonable so far 👍 |
…he file completed
…ction in the camera-upload component
…nt-chart into patient-attachments-app-improvement
ZacButko
suggested changes
Jul 28, 2022
packages/esm-patient-attachments-app/src/attachments/attachments-grid-overview.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-attachments-app/src/attachments/attachments-grid-overview.scss
Outdated
Show resolved
Hide resolved
packages/esm-patient-attachments-app/src/attachments/attachments-grid-overview.scss
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| .closePreviewButton svg path { | ||
| fill: $ui-01 !important; |
| } | ||
|
|
||
| .closePreviewButton:hover svg path { | ||
| fill: $ui-05 !important; |
packages/esm-patient-attachments-app/src/attachments/camera-upload.scss
Outdated
Show resolved
Hide resolved
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| button{ | ||
| max-width: unset !important; |
packages/esm-patient-attachments-app/src/attachments/camera-upload.scss
Outdated
Show resolved
Hide resolved
packages/esm-patient-attachments-app/src/attachments/camera-upload.scss
Outdated
Show resolved
Hide resolved
| grid-template-columns: 1fr 1fr; | ||
|
|
||
| button { | ||
| max-width: unset !important; |
…com/openmrs/openmrs-esm-patient-chart into patient-attachments-app-improvement
ZacButko
approved these changes
Aug 2, 2022
|
|
||
| return ( | ||
| <div className={styles.galleryContainer}> | ||
| {attachments.map((attachment, indx) => { |
There was a problem hiding this comment.
5 letters for index was too expensive? 😂
vasharma05
added a commit
that referenced
this pull request
Aug 3, 2022
This reverts commit d0acf93.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Improvement to the functionality and UI/ UX for patient attachments.
Screenshots
None yet
Related Issue
Other