This repository has been archived by the owner on Sep 10, 2020. It is now read-only.
Fixing bug in deployment and problem with npm start. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldenning
commented
Jun 3, 2019
| @@ -15,8 +15,9 @@ deploy: | |||
| cache-control: "max-age=31536000" | |||
| local_dir: dist | |||
| skip_cleanup: true | |||
| acl: public_read | |||
There was a problem hiding this comment.
This is required to make the uploaded js files available in Digital Ocean spaces
joeldenning
commented
Jun 3, 2019
package.json
Outdated
| @@ -5,7 +5,7 @@ | |||
| "main": "dist/root-config-lib.js", | |||
| "scripts": { | |||
| "clean": "rimraf dist", | |||
| "start": "webpack-dev-server --port", | |||
| "start": "webpack-dev-server", | |||
There was a problem hiding this comment.
The convention established by fatma and me is that to run the project you should do npm start -- --port 8081
joeldenning
commented
Jun 3, 2019
| @@ -24,7 +24,8 @@ module.exports = { | |||
| devServer: { | |||
| headers: { | |||
| "Access-Control-Allow-Origin": "*" | |||
| } | |||
| }, | |||
| disableHostCheck: true | |||
There was a problem hiding this comment.
We need this because we're loading these apps dynamically via SystemJS from urls instead of on a hard coded url and domain.
https://webpack.js.org/configuration/dev-server/#devserverdisablehostcheck
fatmali
approved these changes
Jun 4, 2019
joeldenning
added a commit
that referenced
this pull request
Jun 20, 2019
Fixed Patient Search For Hackathon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.