Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add cohortMemberAttribute & cohortMemberAttributeType #1

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Feat: Add cohortMemberAttribute & cohortMemberAttributeType #1

merged 3 commits into from
Jun 14, 2021

Conversation

corneliouzbett
Copy link
Member

@corneliouzbett corneliouzbett commented Jun 8, 2021 •
edited
Loading

Adds cohortMemberAttribute and cohortMemberAttributeType tables, and APIs

ibacher
ibacher reviewed Jun 8, 2021
View reviewed changes
Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't have any objections here; everything looks good. More a couple of discussion points.

api/src/main/java/org/openmrs/module/cohort/CohortMemberAttribute.java Outdated Show resolved Hide resolved
api/src/main/java/org/openmrs/module/cohort/CohortMemberAttributeType.java Outdated Show resolved Hide resolved
api/src/main/java/org/openmrs/module/cohort/CohortMember.java Outdated Show resolved Hide resolved
@corneliouzbett corneliouzbett merged commit ba08ba1 into master Jun 14, 2021
@corneliouzbett corneliouzbett deleted the feat branch June 14, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibacher ibacher ibacher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliouzbett @ibacher