Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCM-47: Initiate the location mapping user interface #34

Merged
merged 1 commit into from Jun 29, 2021

Conversation

Piumal1999
Copy link
Contributor

The issue I worked on

See https://issues.openmrs.org/browse/DCM-47

Description of what I changed:

Created the User interface of location mapping
This UI displays the mapped location-orgUnits which are saved in the database
Note- Saving/Updating feature will be added under a new JIRA issue

Screenshot 2021-06-23 at 00 32 15

@Piumal1999 Piumal1999 force-pushed the DCM-47 branch 2 times, most recently from 2f77f4d to ef06831 Compare June 23, 2021 14:20
@Piumal1999 Piumal1999 marked this pull request as ready for review June 23, 2021 14:49
Comment on lines 13 to 20

<li
<c:if test='<%= request.getRequestURI().contains("/locationMapping") %>'>class="active"</c:if>>
<a
href="${pageContext.request.contextPath}/module/dhisconnector/locationMapping.form"><spring:message
code="dhisconnector.locationMapping" /></a>
</li>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we fix the formattings of this section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I'll update the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 041fd7b

<tbody>
<c:forEach items="${locations}" var="location">
<tr class="evenRow">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's temove unwanted spaces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I'll update the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 041fd7b

Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Piumal1999!

@jayasanka-sack jayasanka-sack merged commit d42239f into openmrs:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants