DCM-56: Add user privileges to Location Mapping UI #47
Conversation
|
@jayasanka-sack would you be able to take a look at this PR? |
| </c:forEach> | ||
| </select> | ||
| </td> | ||
| <openmrs:hasPrivilege privilege="View Location Mappings,Manage Location Mappings"> |
There was a problem hiding this comment.
thanks @Piumal1999 on ensuring that the person who accesses this page has the required privileges as per your first line,do you really need to re check again at this point for the privileges
There was a problem hiding this comment.
Yeah, you are right @HerbertYiga. I'll remove that line. Thanks for suggesting.
There was a problem hiding this comment.
Fixed with d673db3
There was a problem hiding this comment.
@Piumal1999 I have pointed out a couple of questions.
Could you please check them?
| <openmrs:require anyPrivilege="View Location Mappings,Manage Location Mappings" otherwise="/login.htm" | ||
| redirect="/module/dhisconnector/locationMapping.form"/> |
There was a problem hiding this comment.
What if the user is already logged in, but doesn't have the above permissions? Then redirecting them into the login page will redirect back to the home page. I think it's better if we could make it more informative.
There was a problem hiding this comment.
What if the user is already logged in, but doesn't have the above permissions? Then redirecting them into the login page will redirect back to the home page
yeah @jayasanka-sack. I used the '/login.htm' page because it's the only page that anyone can access. However, the links for these pages are not visible in the navbar. So this redirection will only happen if someone tries to access the page by finding the URL somewhere.
| @@ -35,7 +37,8 @@ | |||
| </c:forEach> | |||
| <input name="savedOrgUnitUuidOf_${location.uuid}" type="hidden" value="${savedOrgUnitUuid}"> | |||
| <td> | |||
| <select name="orgUnitOf_${location.uuid}"> | |||
| <select name="orgUnitOf_${location.uuid}" | |||
| <openmrs:hasPrivilege privilege="Manage Location Mappings" inverse="true">disabled</openmrs:hasPrivilege>> | |||
There was a problem hiding this comment.
It seems the user cannot access this page if the user doesn't have the Manage Location Mappings permission. So this is an unreachable code I guess.
There was a problem hiding this comment.
I went through it again. Ignore this comment.
The issue I worked on
See https://issues.openmrs.org/browse/DCM-56
Description of what I changed:
Updated the Location Mapping UI to behave according to the user privileges
Related Thread and Preview:
https://talk.openmrs.org/t/dhis-connector-module-user-access-controlling/34059/5?u=piumal1999