Test Case for org.openmrs.module.dhisreport.api.adx Package #44
Conversation
| try { | ||
| date3 = DatatypeFactory.newInstance().newXMLGregorianCalendar(new GregorianCalendar(2016, 06, 14)); | ||
| } catch (DatatypeConfigurationException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Don't you just wanna let this bubble through instead of catching it?
|
@dkayiwa I have tried to fix the issues. Is there ok? |
| public class AdxTypeTest { | ||
|
|
||
| @Test | ||
| public void ShouldHaveProperValuesInAllAttributesOfAdxType() throws JAXBException, FileNotFoundException, |
There was a problem hiding this comment.
Can you change the method name to match these conventions? http://www.oracle.com/technetwork/java/codeconventions-135099.html
puevigreven
force-pushed
the
DRM-25-ADX
branch
2 times, most recently
from
b8c0dfa
to
f8d242b
Compare
changing names small change small changes in name
|
@dkayiwa thank you for reviewing it. I have tried to fix the issues. |
|
@puevigreven thanks for the fast response. I just noticed that a fresh checkout of the module fails with a compiler error. Do you think you can look into it? |
|
@dkayiwa I compiled branches master,DRM-25-ImportSummaries,DRM-25-IMPL, DRM-25-ADX and all passed successfully. |
|
@puevigreven oh i see! I was using Java 1.8 |
|
@puevigreven just reverted this because it failed locally for me with: Failed tests: shouldHaveProperValuesInAllAttributesOfAdxType(org.openmrs.module.dhisreport.api.adx.AdxTypeTest): expected:<...07-14T00:00:00.000+0[5:3]0> but was:<...07-14T00:00:00.000+0[3:0]0> |
No description provided.