Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FM2-481: Clean up parameter passing for DiagnosticReport Service Search #511

Merged
merged 1 commit into from Jul 21, 2023

Conversation

mherman22
Copy link
Contributor

@mherman22 mherman22 commented Jul 18, 2023

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/FM2-481

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 86.21% and project coverage change: -0.01 ⚠️

Comparison is base (42b8c45) 77.24% compared to head (835ebc9) 77.23%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #511      +/-   ##
============================================
- Coverage     77.24%   77.23%   -0.01%     
- Complexity     2648     2655       +7     
============================================
  Files           246      247       +1     
  Lines          7426     7440      +14     
  Branches        911      911              
============================================
+ Hits           5736     5746      +10     
- Misses         1142     1145       +3     
- Partials        548      549       +1     
Impacted Files Coverage Δ
...api/search/param/DiagnosticReportSearchParams.java 81.82% <81.82%> (ø)
...hir2/api/impl/FhirDiagnosticReportServiceImpl.java 71.43% <100.00%> (-16.07%) ⬇️
...rs/module/fhir2/api/search/SearchQueryInclude.java 80.89% <100.00%> (ø)
...iders/r3/DiagnosticReportFhirResourceProvider.java 90.91% <100.00%> (+0.43%) ⬆️
...iders/r4/DiagnosticReportFhirResourceProvider.java 68.18% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ibacher ibacher merged commit 7acc81d into openmrs:master Jul 21, 2023
3 of 4 checks passed
@mherman22 mherman22 deleted the FM2-481-DReport branch August 2, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants