-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed code conventions #91
Conversation
Your branch has conflicts which must be resolved. |
Rebase and Squash your commits please. |
@mogoodrich, could you have a look at this? |
@kaine119 @robbyoconnor annoying, this diff is so big github won't show me the whole thing. Kai En, can you summarize what you did? Was it just applying the formatter? Thanks! |
Looks like so! :) |
@mogoodrich: Yes, I did just apply the formatter. I fixed indents, staggered long lines, and added curly braces to some if statements, i.e: if (condition) {
// do stuff
} instead of if (condition)
//do stuff Here's a (mostly accurate) list of changes. |
@kaine119 thanks for the very detailed explanation! |
@ mogoodrich Weird that github can't show you the diff, which browser are you using? |
Chrome. I can see most of it, but it tells me it is too big to show all of it: https://github.com/openmrs/openmrs-module-htmlformentry/pull/91/files (I think I've got all the information I need) |
ok got the same message with Firefox (I was looking at another link). |
@kaine119 I just merged this in, but it resulted in compile errors, so I had to revert. See here: |
https://codein.withgoogle.com/dashboard/task-instances/5021956311089152/
I'm Kai En, from the above Google Code-in task. I've fixed some spelling mistakes and coding conventions.