Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed XSS vulnerability in roles field of user list #139

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Fixed XSS vulnerability in roles field of user list #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions omod/src/main/webapp/admin/users/users.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
<td><c:out value="${user.familyName}"/></td>
<td>
<c:if test="${fn:length(userRolesMap[user]) > 3}">
<span title="${userRolesMap[user]}">
<span title="<c:out value='${userRolesMap[user]}'/>">
</c:if>
<c:forEach var="r" items="${userRolesMap[user]}" varStatus="varStatus" end="2">
<c:choose>
Expand All @@ -102,14 +102,14 @@
<c:when test="${r != role && role != null}">
<span class='bold_text'>
<c:forEach var="inheritedRole" items="${userInheritanceLineMap[user]}" varStatus="inheritanceStatus">
${inheritedRole} <c:if test="${inheritanceStatus.index ne fn:length(userInheritanceLineMap[user]) - 1}"> -> </c:if>
<c:out value='${inheritedRole}'/> <c:if test="${inheritanceStatus.index ne fn:length(userInheritanceLineMap[user]) - 1}"> -> </c:if>
</c:forEach>
</span>
</c:when>
<c:otherwise>${r}</c:otherwise>
<c:otherwise><c:out value='${r}'/></c:otherwise>
</c:choose>
</c:when>
<c:otherwise>, ${r}</c:otherwise>
<c:otherwise>, <c:out value='${r}'/></c:otherwise>
</c:choose>
</c:forEach>
<c:if test="${fn:length(userRolesMap[user]) > 3}">
Expand Down