LBAC-10 Added fix to check the NPE for getAuthenticatedUser() #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Jul 13, 2018
| @@ -54,6 +54,9 @@ public Advice getAdvice() { | |||
| private class PatientSearchAdvise implements MethodInterceptor { | |||
| public Object invoke(MethodInvocation invocation) throws Throwable { | |||
| Object object = invocation.proceed(); | |||
| if (Context.getAuthenticatedUser() == null) { | |||
There was a problem hiding this comment.
Do you need to call invocation.proceed before this?
There was a problem hiding this comment.
No need it before. Just changed
Added fix to check the NPE for getAuthenticatedUser
suthagar23
referenced
this pull request
Jul 13, 2018
…covered with AOP Advices (#13) LBAC-10 Added exception for Daemon thread user to access the methods covered with AOP Advices
|
Can you squash the commits into one? |
|
This PR has only one commit: https://github.com/openmrs/openmrs-module-locationbasedaccess/pull/16/commits Those are the references which linked to other comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added fix to check the NPE for Context.getAuthenticatedUser()
Ticket
Ticket : https://issues.openmrs.org/browse/LBAC-10