Implemented initial design for the location based access control #2
Conversation
|
@dkayiwa Could you have a look at this PR? |
| */ | ||
| public interface AOPService extends Advisor { | ||
|
|
||
| boolean matches(Method method, Class targetClass); |
There was a problem hiding this comment.
I do not think we should create an interface when we do not yet have a use for it.
| import org.openmrs.PersonAttribute; | ||
| import org.springframework.aop.framework.ReflectiveMethodInvocation; | ||
| import java.util.Set; | ||
|
|
There was a problem hiding this comment.
It's a common class for the AOP Methods. We can use for users and patients while accessing the service methods.
|
Let us deal with these one step at a time. Can you start with a real use case from the end user's perspective? Then we implement what is needed to achieve it. |
|
For instance, you can start with something as simple as registering a patient in a specific location. Do this in a way that we can even demo it for the end user. That way, we do not end up with classes and constants we may not use. |
|
Actually, I have tried only for Patients at the beginning, and then I made these common classes which can be used for the users as well. I have created Does this make sense for your question? |
|
That is too much more than what am asking. Look at it this way. If a customer came and told you that all they need is to simply register patients with locations. That is the only code we need for now. |
|
Yah I got it well 😄 I will update the PR soon. |
|
I'm closing this PR, and I will open it while starting work on this. |
Initial design for the location based access control project.
Description
This is an initial design for the location based access control which contains the basic implementation for module. It contains,
Ticket
Ticekt : https://issues.openmrs.org/browse/LBAC-1
Others