Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBAC-15 Added restrictions to the UserService methods to restrict them by the location #22

Merged
merged 1 commit into from Aug 3, 2018

Conversation

@suthagar23
Copy link
Member

@suthagar23 suthagar23 commented Aug 3, 2018

Description

  • Added the restrictions to these following methods from the UserService class which is directly getting the User object from the DAO. It can restrict by the locations while directly accessing the users for some other use cases.

    1. getUsers()
    2. getAllUsers()
    3. getUser()
    4. getUserByUuid()
    5. getUserByUsername()
    6. getUserByName()
    7. getUsersByPerson()
  • Added a method to restrict person object of the users since we haven't assigned the person attribute for those persons belongs to the users.

Ticket

Ticket : https://issues.openmrs.org/browse/LBAC-15

@suthagar23
Copy link
Member Author

@suthagar23 suthagar23 commented Aug 3, 2018

@dkayiwa Could you have a look at this PR?

@dkayiwa
Copy link
Member

@dkayiwa dkayiwa commented Aug 3, 2018

Which user interface page did you test this with? Can you attach some screenshots on the ticket?

@suthagar23 suthagar23 force-pushed the suthagar23:LBAC-15 branch 2 times, most recently from d605f76 to 4f487fe Aug 3, 2018
@suthagar23
Copy link
Member Author

@suthagar23 suthagar23 commented Aug 3, 2018

I just tested with the User Management interface @dkayiwa . Person Eric Brain has two users as brain1(loc - Inpatient) and brain2(loc - Isolation). See here,

image

image

image

…m by the location
@suthagar23 suthagar23 force-pushed the suthagar23:LBAC-15 branch from 4f487fe to 41bd4cc Aug 3, 2018
@dkayiwa dkayiwa merged commit 3394a32 into openmrs:master Aug 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants