LBAC-15 Added restrictions to the UserService methods to restrict them by the location #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkayiwa Could you have a look at this PR? |
|
Which user interface page did you test this with? Can you attach some screenshots on the ticket? |
suthagar23
force-pushed
the
LBAC-15
branch
2 times, most recently
from
d605f76
to
4f487fe
Compare
|
I just tested with the User Management interface @dkayiwa . Person Eric Brain has two users as brain1(loc - Inpatient) and brain2(loc - Isolation). See here,
|
…m by the location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the restrictions to these following methods from the UserService class which is directly getting the User object from the DAO. It can restrict by the locations while directly accessing the users for some other use cases.
Added a method to restrict person object of the users since we haven't assigned the person attribute for those persons belongs to the users.
Ticket
Ticket : https://issues.openmrs.org/browse/LBAC-15