RAD-172 Clean radiology_report db #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the database radiology_report * column radiology_report_id ** rename to report_id * column order_id ** add not null constraint (a report must not exist without order) * column report_status ** shrink size to max enum of RadiologyReportStatus which is DISCONTINUED -> 12 ** add not null constraint * column principalResultsInterpreter_id ** rename to principal_results_interpreter * column creator ** add not null constraint, defauts to '0' * column creationDate ** rename to date_created ** convert type to datetime ** add not null constraint * rename foreign key constraints to "tablename_columname_fk" * remove setting dateCreated in RadiologyReport constructor since its done by AuditableInterceptor
teleivo
added a commit
that referenced
this pull request
Mar 22, 2016
RAD-172 Clean radiology_report db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the database radiology_report
** rename to report_id
** add not null constraint (a report must not exist without order)
** shrink size to max enum of RadiologyReportStatus which is DISCONTINUED -> 12
** add not null constraint
** rename to principal_results_interpreter
** add not null constraint, defauts to '0'
** rename to date_created
** convert type to datetime
** add not null constraint
done by AuditableInterceptor
see https://issues.openmrs.org/browse/RAD-172