Add travis ci build #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
teleivo
commented
May 16, 2015
teleivo
commented
- add travis ci yaml configuration
- embed travis ci build status in readme
* move Radiology.hbm.xml from omod/src/main/resources to api/src/main/resources
(because the api is closer to the db model/definition, it seems to be a more
appropriate place)
* more important BaseModuleContextSensitiveTest which will be added to the api need access to
Radiology.hbm.xml otherwise they do not run
* add maven-dependency-plugin to copy Radiology.hbm.xml into the omod package
(and thus the BaseModuleWebContextSensitiveTest added to it at a later stage)
* replace ${omodHbmConfig} in omods config.xml with a static reference to Radiology.hbm.xml
since the omod plugin can only populate it for mappingFiles which are
resources of the omod itself
* add resource api/src/main/resources to api pom
fixes eclipse error: Plugin execution not covered by lifecycle configuration: org.openmrs.maven.plugins:maven-openmrs-plugin:1.0.1:initialize-module (execution: init, phase:initialize)
* thus enforce type safety * extract Modality enum in own file since its used not only in Study * remove unused Modality.getAllFullNames() * store modalities enum name in database instead of ordinal to be independent of enum order * pass modalities map to radiologyOrderForm
* add StudyValidator to ensure modality is non-null * do not persist if spring binderrors exist
DICOM images are no longer received and stored locally by this module but instead by dcm4chee or any other PACS, thus * remove dcm4che libraries dcmrcv * remove unused globalProperties configuring dcmrcv from config.xml
replace study.orderId by study.order * effort to reduce contact surface with deprecated OrderService * StudyValidator prevents study.order == null * adapt web to study.order move service requests from from Study to radiology service (Main) * getStudiesByOrders(List<Order>) replaces Study.get(List<Order>) * getObservationsByStudy() replaces Study.get() * GenericDAO is not referenced anymore and can thus be removed * remove saveStudy(Study, Date) since parameter Date is never used. only use saveStudy(Study) * saveStudy(Study) now sets study.uid to move this logic from the web part (RadiologyOrderFormController) into the api * rewrite Study.toString() following openmrs-core/Order.toString() * change study.id from int to Integer * add MainTest (with RadiologyServiceTestDataSet.xml) to test the api
* updateStudyPerformedStatus(Study, PerformedStatus) should be called when MPPS is received
* use Main.updateStudyPerformedStatus() to update studies performed status
* selection of modality is not lost anymore when trying to enter an invalid order
* fixes "port already in use" if you start and stop the module
* add Enum PerformedProcedureStepStatus * change member Study.performedStatus from type int to PerformedProcedureStepStatus * adjust hibernate mapping * add liquibase changeset removing default value -1 since this value is not represented by the Enum PerformedProcedureStepStatus
* add Enum RequestedProcedurePriority * change member Study.priority from type int to RequestedProcedurePriority * adjust hibernate mapping to store enum ordinal value, set not-null=true * add liquibase changeset removing default value -1, since enum ordinal value starts at 0. add a not null constraint. * RadiologyServiceImpl.saveStudy(Study) sets Study.priority to ROUTINE if null
* add Enum ScheduledProcedureStepStatus * change member Study.scheduledStatus from type int to ScheduledProcedureStepStatus * adjust hibernate mapping to store enum ordinal value * add liquibase changeset removing default value -1, since enum ordinal value starts at 0
* add Enum MwlStatus * change member Study.mwlStatus from type int to MwlStatus * adjust hibernate mapping to store enum ordinal value, set not-null = true * add liquibase changeset removing default value -1, since enum ordinal value starts at 0, and add not null contraint * set mwlStatus = MwlStatus.Default in Study
remove api context from Study, so that it becomes a simple model * do not set a default concept when saving a study. default concept was set since its mandatory to create an order but setting it to "Blood Loss" does not seem appropriate * set Study.scheduledStatus to SCHEDULED if order.startDate was set in RadiologyServiceImpl.saveStudy(). plus fixes bug, only set Study.scheduledStatus if not null otherwise you override for example if the user selects an orderStartDate and chooses Study.scheduledStatus = ARRIVED * set performing, reading physician and scheduler in api saveStudy() if not null, to the orderer if he has the appropriate roles * set studyId, order and ordertype in omod which is responsible for passing a valid study to the radiologyservice api to save it
* for readability. first GET, than POST request
* switch if branches, since its easier to read conditionals testing for positive than negative statements
improves readability * fix omod test-hibernate.cfg.xml reference to hibernate mapping * add tests for RadiologyOrderFormController all methods handling GET requests * add test dataset to omod
* more appropriate to pass objects with all mandatory fields set (like Order.orderType) which the user wont enter. POST request should not have to set the orderType
* extract "saveOrder" in own POST requestMethod in RadiologyOrderFormController. validating order and study did prevent orders from being voided, unvoided, discontinued, undiscontinued.
* add travis ci yaml configuration * embed travis ci build status in readme
|
split PRs up into smaller ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.