Rename date methods in SearchCriteriaBuilders #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .withPrincipalResultsInterpreter(principalResultsInterpreter) | ||
| .withStatus(status) | ||
| .build(); | ||
| radiologyReportSearchCriteriaBuilder = radiologyReportSearchCriteriaBuilder.includeVoided(); |
There was a problem hiding this comment.
@Schwarz94 no need to reassign is it?
There was a problem hiding this comment.
Should be possible to do
builder.includeVoided()
builder.withThisAndThat()
Criteria crit = builder.build()
|
@Schwasrz94 please also add the class level javadoc |
* rename withFromEffectiveStartDate to fromEffectiveStartDate, withToEffectiveStartDate to toEffectiveStartDate in RadiologyOrderSearchCriteria.java * rename withFromDate to fromDate, withToDate to toDate in RadiologyReportSearchCriteria.java * modify construction of RadiologyReportSearchCriteria * extand javadocs of search criteria classes * fix report date filter bug
durac
pushed a commit
to durac/openmrs-module-radiology
that referenced
this pull request
Aug 11, 2016
Rename date methods in SearchCriteriaBuilders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
withToEffectiveStartDate to toEffectiveStartDate in
RadiologyOrderSearchCriteria.java
RadiologyReportSearchCriteria.java